Update SonarX blurb with Tempo-specific datasets#182
Merged
Conversation
…sitioning Amp-Thread-ID: https://ampcode.com/threads/T-019cff4f-3ed6-7190-8890-8b61235793d9 Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tx-tomcat
pushed a commit
to Magnus-Foundation/magnus
that referenced
this pull request
Apr 18, 2026
Currently, the TIP20::from_address function, does not check if the address actually has the TIP20 prefix. This leads to random errors like PrecompileOOG, when it is used in places like the StablecoinDex. Eg. tempoxyz/docs#182 (comment) We add an InvalidToken() error specifically for this case in this PR. TBD: @0xKitsune is there a reason why we use unchecked address to tokenId conversion here - https://github.com/tempoxyz/tempo/blob/main/crates/precompiles/src/tip20/mod.rs#L640 If not, then we could move this invalid token check inside the TIP20 fns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates SonarX description with their institutional positioning and Tempo-specific coverage details (Full Historical Stream Dataset, Real-Time Dataset, delivery via Snowflake/Databricks/BigQuery/Kafka/APIs). Also fixes bare URL in CTA.